Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.7, 3.8 support, improved unittest support #7

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

nanobowers
Copy link

This PR also contains some edits based on a fork from @Fryguy - namely support for F-Strings.

Enhancements:

  • Support for python 3.7 up to python 3.8.6 has been added. For some reason I am having trouble getting py3.9 to work at the moment, hope to revisit that later. (Support for Python 3.8 #6 per @ankane)
    • Integrated @Fryguy f-string support (visit_JoinedStr, visit_FormattedValue) support for some fstring modifiers (e.g. {foo!r}) and added unit tests.
    • Added support for visit_Constant from 3.8+
  • Added try/except in run_tests.py to pre-check existence of development package dependencies before failing (Test [FAIL] #5 @joel)
  • Added support for many additional python unitTest --> ruby test/unit, and consolidated testing files somewhat.

@Fryguy
Copy link

Fryguy commented Feb 5, 2021

I totally forgot I forked it with that fix 😆

Copy link

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This WFM on Python 3.8-3.10.0b3, on Mac BigSur 11.4

@@ -0,0 +1,256 @@
# py2rb.py
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing README.rst and creating README.md causes pip install 'git+https://github.com/nanobowers/py2rb@new_versions' to fail because setup.py requires README.rst.

@jayvdb
Copy link

jayvdb commented Jul 4, 2021

ping @naitoh , could you review this. I would like to make other PRs, but it doesnt make sense to do that unless this is merged as I need py38+ support.

@nanobowers
Copy link
Author

Hi @jayvdb, I am hopeful that @naitoh returns, but it appears he has been inactive for quite some time.

I have recently made some fixes to my repo that address some of the issues you filed:

Please feel free to submit issues/PRs there if you wish.

Hopefully we can get clarification if this repo is abandoned and (if so) figure out if it can be handed off to someone else.

@jayvdb
Copy link

jayvdb commented Jul 6, 2021

Great. There are now two main bugs found by the py2many test suite

And one that is not as critical

I think I saw that @naitoh was active on Twitter. Might want to catch him there or on email, to find out the future of this package.

@nanobowers
Copy link
Author

nanobowers commented Jul 22, 2021

I think I saw that @naitoh was active on Twitter. Might want to catch him there or on email, to find out the future of this package.

@jayvdb So far, attempts to reach @naitoh outside of GitHub have been unsuccessful. Not sure the best way to proceed is...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants